linux-kernel - Re: [PATCH] perf tools: fix build for various architectures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA6FOTd95tN4WW8KAqD5tVsGs7TTU40zLXr2mkdPRse+mg@mail.gmail.com>
Date:	Tue, 27 Nov 2012 09:41:18 -0500
From:	Josh Boyer <jwboyer@...il.com>
To:	Mark Rutland <mark.rutland@....com>
Cc:	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	David Howells <dhowells@...hat.com>,
	Deng-Cheng Zhu <dengcheng.zhu@...il.com>,
	Ingo Molnar <mingo@...hat.com>,
	Kyle McMartin <kyle@...artin.ca>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Tony Luck <tony.luck@...el.com>,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH] perf tools: fix build for various architectures

On Tue, Nov 27, 2012 at 7:16 AM, Mark Rutland <mark.rutland@....com> wrote:
> The UAPI changes broke the perf tool, and as of 3.7-rc7, it
> still won't build for arm:
>
>         In file included from util/../perf.h:81:0,
>                          from util/cache.h:7,
>                          from perf.c:12:
>         util/../../../arch/arm/include/asm/unistd.h:16:29: fatal error: uapi/asm/unistd.h: No such file or directory
>         compilation terminated.
>         make: *** [perf.o] Error 1
>
> It seems the perf tool build infrastructure can't map <uapi/*> paths,
> and several architectures (arm, arm64, ia64, mips, parisc, powerpc,
> s390) include <uapi/asm/unistd.h> from their <asm/unistd.h>.
>
> This patch copies 77626081: "perf tools: Fix build on sparc." in simply
> changing the path to use arch/arm/include/uapi/asm/unistd.h directly for
> all of these cases.
>
> I've tested this on arm, but I don't have the necessary toolchains to
> check the other cases.
>
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> Cc: David Howells <dhowells@...hat.com>
> Cc: Deng-Cheng Zhu <dengcheng.zhu@...il.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Kyle McMartin <kyle@...artin.ca>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: Will Deacon <will.deacon@....com>
> ---
>  tools/perf/perf.h |   14 +++++++-------
>  1 files changed, 7 insertions(+), 7 deletions(-)

This is correct, but it shouldn't be needed.  Arnaldo has a pull request
out to Ingo that should fix the build issues on all architectures in a
more generic way.  See:

http://article.gmane.org/gmane.linux.kernel.cross-arch/15974

I'm really hoping that gets into Linus' tree ASAP or 3.7 will ship with
a broken perf on non-x86.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/