lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Nov 2012 10:23:33 -0500 From: chas williams - CONTRACTOR <chas@....nrl.navy.mil> To: David Woodhouse <dwmw2@...radead.org> Cc: Krzysztof Mazur <krzysiek@...lesie.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, davem@...emloft.net Subject: Re: [PATCH v3 8/7] pppoatm: fix missing wakeup in pppoatm_send() On Tue, 27 Nov 2012 13:27:47 +0000 David Woodhouse <dwmw2@...radead.org> wrote: > > i really would prefer not to use a strange name since it might confuse > > larger group of people who are more familiar with the traditional meaning > > of this function. vcc_release() isnt exported so we could rename it if > > things get too confusing. > > > > i have to look at this a bit more but we might be able to use release_cb > > to get rid of the null push to detach the underlying protocol. that would > > be somewhat nice. > > In the meantime, should I resend this patch with the name 'release_cb' > instead of 'unlock_cb'? I'll just put a comment in to make sure it isn't > confused with vcc_release(), and if we need to change vcc_release() > later we can. > yes, but dont call it 8/7 since that doesnt make sense. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists