[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1354032951.4266.61.camel@deadeye.wl.decadent.org.uk>
Date: Tue, 27 Nov 2012 16:15:51 +0000
From: Ben Hutchings <ben@...adent.org.uk>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org,
kernel-team@...ts.ubuntu.com, Johan Hovold <jhovold@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
Subject: Re: [PATCH 245/270] USB: mct_u232: fix broken close
On Mon, 2012-11-26 at 14:58 -0200, Herton Ronaldo Krzesinski wrote:
> 3.5.7u1 -stable review patch. If anyone has any objections, please let me know.
>
> ------------------
>
> From: Johan Hovold <jhovold@...il.com>
>
> commit 5260e458f5eff269a43e4f1e9c47186c57b88ddb upstream.
>
> Make sure generic close is called at close.
>
> The driver relies on the generic write implementation but did not call
> generic close.
>
> Note that the call to kill the read urb is not redundant, as mct_u232
> uses an interrupt urb from the second port as the read urb and that
> generic close therefore fails to kill it.
>
> Compile-only tested.
>
> Signed-off-by: Johan Hovold <jhovold@...il.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Herton Ronaldo Krzesinski <herton.krzesinski@...onical.com>
[...]
This is missing on 3.4; the version I used for 3.2 (attached) should be
applicable.
Ben.
--
Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.
View attachment "usb-mct_u232-fix-broken-close.patch" of type "text/x-patch" (1478 bytes)
Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)
Powered by blists - more mailing lists