linux-kernel - Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50B50985.1010700@infradead.org>
Date:	Tue, 27 Nov 2012 10:42:13 -0800
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] staging/fwserial: Fix build breakage when !CONFIG_BUG

On 11/26/2012 11:11 PM, Peter Hurley wrote:

> Use WARN() as intended.
> 
> Signed-off-by: Peter Hurley <peter@...leysoftware.com>


Reported-by: Randy Dunlap <rdunlap@...radead.org>
Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/staging/fwserial/dma_fifo.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c
> index 72aa053..5e84634 100644
> --- a/drivers/staging/fwserial/dma_fifo.c
> +++ b/drivers/staging/fwserial/dma_fifo.c
> @@ -33,10 +33,7 @@
>  
>  #define FAIL(fifo, condition, format...) ({				\
>  	fifo->corrupt = !!(condition);					\
> -	if (unlikely(fifo->corrupt)) {					\
> -		__WARN_printf(format);					\
> -	}								\
> -	unlikely(fifo->corrupt);					\
> +	WARN(fifo->corrupt, format);					\
>  })
>  
>  /*



-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/