linux-kernel - Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50B53E37.40303@samsung.com>
Date:	Wed, 28 Nov 2012 07:27:03 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	Olof Johansson <olof@...om.net>
CC:	Doug Anderson <dianders@...omium.org>,
	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

On 11/28/12 07:11, Olof Johansson wrote:
> On Tue, Nov 27, 2012 at 11:53 AM, Doug Anderson<dianders@...omium.org>  wrote:
>> The recent commit "ARM: EXYNOS: add support for EXYNOS5440 SoC" broke
>> support for exynos5250 because of_machine_is_compatible() was used too
>> early in the boot process.  It also probably meant that the exynos5440
>> failed to use the proper iotable.  Switch to use
>> of_flat_dt_is_compatible() in both of these cases.
>>
>> The failure I was seeing in exynos5250 because of this was:
>>    Division by zero in kernel.
>>    [<80015ed4>] (unwind_backtrace+0x0/0xec) from [<8045c7a4>] (dump_stack+0x20/0x24)
>>    [<8045c7a4>] (dump_stack+0x20/0x24) from [<80012990>] (__div0+0x20/0x28)
>>    [<80012990>] (__div0+0x20/0x28) from [<8021ab04>] (Ldiv0_64+0x8/0x18)
>>    [<8021ab04>] (Ldiv0_64+0x8/0x18) from [<80068560>] (__clocksource_updatefreq_scale+0x54/0x134)
>>    [<80068560>] (__clocksource_updatefreq_scale+0x54/0x134) from [<8006865c>] (__clocksource_register_scale+0x1c/0x54)
>>    [<8006865c>] (__clocksource_register_scale+0x1c/0x54) from [<80612a18>] (exynos_timer_init+0x100/0x1e8)
>>    [<80612a18>] (exynos_timer_init+0x100/0x1e8) from [<8060d184>] (time_init+0x28/0x38)
>>    [<8060d184>] (time_init+0x28/0x38) from [<8060a754>] (start_kernel+0x1e0/0x3c8)
>>    [<8060a754>] (start_kernel+0x1e0/0x3c8) from [<40008078>] (0x40008078)
>>
>> Signed-off-by: Doug Anderson<dianders@...omium.org>
>
> Thanks Doug.
>
> Kukjin, I'll apply this directly on top of the previous branch in
> arm-soc, if that's OK with you.
>
Sure, go ahead with my ack if you want,

Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Note, actually there was a fix which uses soc_is_exynos5440() in my 
local :-) I'm not sure which one is better at this moment, but I'm OK on 
this.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/