linux-kernel - [PATCH] sound/sgtl5000: fix initial setting for DAC data source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	28 Nov 2012 10:14:28 +0000
From:	"Oskar Schirmer" <oskar@...ra.com>
To:	"Wolfram Sang" <w.sang@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Liam Girdwood" <lrg@...com>,
	"Fabio Estevam" <fabio.estevam@...escale.com>,
	"Zeng Zhaoming" <zengzm.kernel@...il.com>,
	alsa-devel@...a-project.org, "Jaroslav Kysela" <perex@...ex.cz>,
	"Takashi Iwai" <tiwai@...e.de>, "Oskar Schirmer" <oskar@...ra.com>
Subject: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

According to documentation bit 3:2 in register SSS_CTRL are
reserved and zero, so the setting of 0x0008 does not make much sense.
Instead, bit 4 should be set as is with power up, to reflect
routing of I2S_IN to DAC correctly.

Looks much like an off by one error.

Signed-off-by: Oskar Schirmer <oskar@...ra.com>
---
 sound/soc/codecs/sgtl5000.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index df2f99d..5b37891 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -37,7 +37,7 @@
 static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] =  {
 	[SGTL5000_CHIP_CLK_CTRL] = 0x0008,
 	[SGTL5000_CHIP_I2S_CTRL] = 0x0010,
-	[SGTL5000_CHIP_SSS_CTRL] = 0x0008,
+	[SGTL5000_CHIP_SSS_CTRL] = 0x0010,
 	[SGTL5000_CHIP_DAC_VOL] = 0x3c3c,
 	[SGTL5000_CHIP_PAD_STRENGTH] = 0x015f,
 	[SGTL5000_CHIP_ANA_HP_CTRL] = 0x1818,
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/