linux-kernel - Re: [PATCH v4 2/2] therma: exynos: Supports thermal tripping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 28 Nov 2012 16:51:09 +0530
From:	Amit Kachhap <amit.kachhap@...aro.org>
To:	Jonghwan Choi <jhbird.choi@...sung.com>
Cc:	open list <linux-kernel@...r.kernel.org>,
	Zhang Rui <rui.zhang@...el.com>,
	Sachin Kamat <sachin.kamat@...aro.org>
Subject: Re: [PATCH v4 2/2] therma: exynos: Supports thermal tripping

On 26 November 2012 07:01, Jonghwan Choi <jhbird.choi@...sung.com> wrote:
> TMU urgently sends active-high signal (thermal trip) to PMU,
> and thermal tripping by hardware logic i.e PMU is performed.
> Thermal tripping means that PMU cut off the whole power of SoC
> by controlling external voltage regulator.
>
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
> ---
>  drivers/thermal/exynos_thermal.c |   21 +++++++++++++++++----
>  1 files changed, 17 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/exynos_thermal.c
> b/drivers/thermal/exynos_thermal.c
> index 129e827..f0ce099 100644
> --- a/drivers/thermal/exynos_thermal.c
> +++ b/drivers/thermal/exynos_thermal.c
> @@ -631,6 +631,12 @@ static int exynos_tmu_initialize(struct platform_device
> *pdev)
>                         goto out;
>                 }
>                 rising_threshold |= (threshold_code << 16);
> +               threshold_code = temp_to_code(data,
> pdata->trigger_levels[3]);
> +               if (threshold_code < 0) {
> +                       ret = threshold_code;
> +                       goto out;
> +               }
> +               rising_threshold |= (threshold_code << 24);
>
>                 writel(rising_threshold,
>                                 data->base + EXYNOS_THD_TEMP_RISE);
> @@ -669,10 +675,14 @@ static void exynos_tmu_control(struct platform_device
> *pdev, bool on)
>
>         if (on) {
>                 con |= EXYNOS_TMU_CORE_ON;
> -               interrupt_en = pdata->trigger_level3_en << 12 |
> -                       pdata->trigger_level2_en << 8 |
> +               interrupt_en = pdata->trigger_level2_en << 8 |
>                         pdata->trigger_level1_en << 4 |
>                         pdata->trigger_level0_en;
> +
> +               if (data->soc == SOC_ARCH_EXYNOS4210)
> +                       interrupt_en |= pdata->trigger_level3_en << 12;
> +               else
> +                       con |= pdata->trigger_level3_en << 12;
>         } else {
>                 interrupt_en = 0; /* Disable all interrupts */
>         }
> @@ -770,6 +780,7 @@ static struct exynos_tmu_platform_data const
> exynos_default_tmu_data = {
>         .trigger_levels[0] = 85,
>         .trigger_levels[1] = 103,
>         .trigger_levels[2] = 110,
> +       .trigger_levels[3] = 120,
>         .trigger_level0_en = 1,
>         .trigger_level1_en = 1,
>         .trigger_level2_en = 1,
> @@ -917,8 +928,10 @@ static int __devinit exynos_tmu_probe(struct
> platform_device *pdev)
>         /* Register the sensor with thermal management interface */
>         (&exynos_sensor_conf)->private_data = data;
>         exynos_sensor_conf.trip_data.trip_count = pdata->trigger_level0_en +
> -                       pdata->trigger_level1_en + pdata->trigger_level2_en
> +
> -                       pdata->trigger_level3_en;
> +                       pdata->trigger_level1_en + pdata->trigger_level2_en;
> +
> +       if (data->soc == SOC_ARCH_EXYNOS4210)
> +               exynos_sensor_conf.trip_data.trip_count +=
> pdata->trigger_level3_en;

Hi Choi,

Your changes looks fine but I guess we are changing a common code. I
(Along with  jonghwa3.lee@...sung.com ) have submitted a patchset
which will simplify this and now this 4th trip point code addition for
exynos4210 will be mostly platform data addition, So let Zhang Ru
comment on my changes because this will cause merge conflict.

Thanks,
Amit D
>
>         for (i = 0; i < exynos_sensor_conf.trip_data.trip_count; i++)
>                 exynos_sensor_conf.trip_data.trip_val[i] =
> --
> 1.7.4.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/