linux-kernel - Re: [PATCH v4 0/3] pwm: Drivers for twl4030/6030 PWMs and LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121128141957.GA21042@avionic-0098.adnet.avionic-design.de>
Date:	Wed, 28 Nov 2012 15:20:00 +0100
From:	Thierry Reding <thierry.reding@...onic-design.de>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Tero Kristo <t-kristo@...com>,
	Grazvydas Ignotas <notasas@...il.com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	devicetree-discuss@...ts.ozlabs.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>, linux-doc@...r.kernel.org
Subject: Re: [PATCH v4 0/3] pwm: Drivers for twl4030/6030 PWMs and LEDs

On Tue, Nov 27, 2012 at 11:09:56AM +0100, Peter Ujfalusi wrote:
> Hello,
> 
> Changes since v3:
> - pwm-twl-led driver's comment fix patch squashed to the original patch
> - Documentation for the DT bindings of the PWM drivers
> Comments from Thierry Reding addressed:
> - pwm-twl6030 has been removed in the last patch
> - macro for twl_pwm_chip/twl_pwmled_chip lookup
> - locking for read-modify-write sequences
> - separate pwm_ops strictures for twl4030 and twl6030 class
> - _devexit_P() removed
> - Do not select HAVE_PWM in Kconfig file since it is going away AFAIK:
>   https://patchwork.kernel.org/patch/1544851/
> - Remaining (smaller) comments from Thierry also has been addressed.
> 
> Changes since v2:
> - New PWM cycle calculation for twl-pwm driver and twl4030's pwm-twl-led with
>   comment to document the expected behaviour.
> 
> Changes cince v1:
> - The turn on/off sequence has been corrected for twl4030 PWMs as suggested by
>   Grazvydas Ignotas
> - Comment section added to the new drivers to describe what they are controlling
> 
> The series has been tested (with additional, pending patches):
> Zoom2 for twl4030 PWM0 (keypad light), PWM1 (LCD backlight)
> BeagleBoard for twl4030 LEDB (PWMB - pmu_stat led)
> OMAP4 Blaze (SDP4430) for twl6030 PWM1 (keypad light), PWM2 (LCD backlight) and
> LED (charging indication led).
> 
> Intro mail from v1:
> 
> The currently available pwm-twl6030.c driver only supports TWL6030's Charging
> indication LED.
> Remove this driver and add two new ones which implements support for all PWM
> driven outputs:
> pwm-twl driver supports twl4030 (PWM 0/1) and twl6030 (PWM 1/2) instances
> pwm-twl-led driver supports twl4030 (PWM driven LED A/B ports) and twl6030's
> Charging indication LED (PWM driven).
> 
> Regards,
> Peter
> ---
> Peter Ujfalusi (3):
>   pwm: New driver to support PWMs on TWL4030/6030 series of PMICs
>   pwm: New driver to support PWM driven LEDs on TWL4030/6030 series of
>     PMICs
>   pwm: Remove pwm-twl6030 driver
> 
>  .../devicetree/bindings/pwm/ti,twl-pwm.txt         |  17 +
>  .../devicetree/bindings/pwm/ti,twl-pwmled.txt      |  17 +
>  drivers/pwm/Kconfig                                |  17 +-
>  drivers/pwm/Makefile                               |   3 +-
>  drivers/pwm/pwm-twl-led.c                          | 342 ++++++++++++++++++++
>  drivers/pwm/pwm-twl.c                              | 357 +++++++++++++++++++++
>  drivers/pwm/pwm-twl6030.c                          | 184 -----------
>  7 files changed, 748 insertions(+), 189 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwm.txt
>  create mode 100644 Documentation/devicetree/bindings/pwm/ti,twl-pwmled.txt
>  create mode 100644 drivers/pwm/pwm-twl-led.c
>  create mode 100644 drivers/pwm/pwm-twl.c
>  delete mode 100644 drivers/pwm/pwm-twl6030.c

Applied with minor fixups, thanks.

Thierry

Content of type "application/pgp-signature" skipped