linux-kernel - Re: [PATCH] ext4: fixed ext4_calculate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20121128174515.GC24431@thunk.org>
Date:	Wed, 28 Nov 2012 12:45:15 -0500
From:	Theodore Ts'o <tytso@....edu>
To:	Vahram Martirosyan <vmartirosyan@...il.com>
Cc:	Vahram Martirosyan <vmartirosyan@...uxtesting.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: fixed ext4_calculate_overhead() bug.

On Wed, Nov 21, 2012 at 04:28:21PM -0800, Vahram Martirosyan wrote:
> The memset operation before check brings to a BUG.
> No need to memset the page with zeroes.
> 
> The patch removes the memset call in ext4_calculate_overhead() function.
> 
> Found by the Spruce system in cooperation with the KEDR Framework.
> 
> Signed-off-by: Vahram Martirosyan <vmartirosyan@...uxtesting.org>

Applied, with a slightly rewritten commit description:

    ext4: fixed potential NULL dereference in ext4_calculate_overhead()
    
    The memset operation before check can cause a BUG if the memory
    allocation failed.  Since we are using get_zeroed_age, there is no
    need to use memset anyway.
    
    Found by the Spruce system in cooperation with the KEDR Framework.
    
    Signed-off-by: Vahram Martirosyan <vmartirosyan@...uxtesting.org>
    Signed-off-by: "Theodore Ts'o" <tytso@....edu>

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/