linux-kernel - Re: [PATCH v2] rtc: Add NXP PCF8523 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121128153158.ba24124e.akpm@linux-foundation.org>
Date:	Wed, 28 Nov 2012 15:31:58 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtc: Add NXP PCF8523 support

On Wed, 28 Nov 2012 20:21:26 +0100
Thierry Reding <thierry.reding@...onic-design.de> wrote:

> +	err = i2c_transfer(client->adapter, &msg, 1);
> +	if (err < 0) {
> +		/*
> +		 * If the time cannot be set, restart the RTC anyway. Note
> +		 * that errors are ignored if the RTC cannot be started so
> +		 * that we have a chance to propagate the original error.
> +		 */
> +		pcf8523_start_rtc(client);
> +		return err;
> +	}
> +
> +	return pcf8523_start_rtc(client);

hm, well, that is of course equivalent to

	err = i2c_transfer(client->adapter, &msg, 1);
	pcf8523_start_rtc(client);
	return err;

but I suppose the code as proposed is clear, extensible, and not our
worst-ever sin ;)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/