linux-kernel - linux-next: manual merge of the driver-core tree with the battery tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121129151142.320443bcfadad110dcc88722@canb.auug.org.au>
Date:	Thu, 29 Nov 2012 15:11:42 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Greg KH <greg@...ah.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bill Pemberton <wfp5p@...ginia.edu>,
	"Rajanikanth H.V" <rajanikanth.hv@...ricsson.com>,
	Anton Vorontsov <avorontsov@...mvista.com>
Subject: linux-next: manual merge of the driver-core tree with the battery
 tree

Hi Greg,

Today's linux-next merge of the driver-core tree got a conflict in
drivers/power/ab8500_charger.c between commit 4aef72dbb2e8 ("ab8500: Add
devicetree support for charger") from the battery tree and commit
c8afa6406e60 ("power: remove use of __devinit") from the driver-core tree.

I fixed it up (see below) and can carry the fix as necessary (no action
is required).

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

diff --cc drivers/power/ab8500_charger.c
index dddc947,7ecb8ab..0000000
--- a/drivers/power/ab8500_charger.c
+++ b/drivers/power/ab8500_charger.c
@@@ -2532,41 -2531,20 +2532,41 @@@ static int ab8500_charger_remove(struc
  	return 0;
  }
  
 +static char *supply_interface[] = {
 +	"ab8500_chargalg",
 +	"ab8500_fg",
 +	"ab8500_btemp",
 +};
 +
- static int __devinit ab8500_charger_probe(struct platform_device *pdev)
+ static int ab8500_charger_probe(struct platform_device *pdev)
  {
 -	int irq, i, charger_status, ret = 0;
 -	struct abx500_bm_plat_data *plat_data = pdev->dev.platform_data;
 +	struct device_node *np = pdev->dev.of_node;
  	struct ab8500_charger *di;
 +	int irq, i, charger_status, ret = 0;
  
 -	if (!plat_data) {
 -		dev_err(&pdev->dev, "No platform data\n");
 -		return -EINVAL;
 -	}
 -
 -	di = kzalloc(sizeof(*di), GFP_KERNEL);
 -	if (!di)
 +	di = devm_kzalloc(&pdev->dev, sizeof(*di), GFP_KERNEL);
 +	if (!di) {
 +		dev_err(&pdev->dev, "%s no mem for ab8500_charger\n", __func__);
  		return -ENOMEM;
 +	}
 +	di->bat = pdev->mfd_cell->platform_data;
 +	if (!di->bat) {
 +		if (np) {
 +			ret = bmdevs_of_probe(&pdev->dev, np, &di->bat);
 +			if (ret) {
 +				dev_err(&pdev->dev,
 +					"failed to get battery information\n");
 +				return ret;
 +			}
 +			di->autopower_cfg = of_property_read_bool(np, "autopower_cfg");
 +		} else {
 +			dev_err(&pdev->dev, "missing dt node for ab8500_charger\n");
 +			return -EINVAL;
 +		}
 +	} else {
 +		dev_info(&pdev->dev, "falling back to legacy platform data\n");
 +		di->autopower_cfg = false;
 +	}
  
  	/* get parent data */
  	di->dev = &pdev->dev;
@@@ -2765,14 -2760,12 +2765,14 @@@ free_charger_wq
  	return ret;
  }
  
 +static const struct of_device_id ab8500_charger_match[] = {
 +	{ .compatible = "stericsson,ab8500-charger", },
 +	{ },
 +};
 +
  static struct platform_driver ab8500_charger_driver = {
  	.probe = ab8500_charger_probe,
- 	.remove = __devexit_p(ab8500_charger_remove),
+ 	.remove = ab8500_charger_remove,
  	.suspend = ab8500_charger_suspend,
  	.resume = ab8500_charger_resume,
  	.driver = {

Content of type "application/pgp-signature" skipped