linux-kernel - Re: [RFQ PATCH] cifs: Change default security error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mvKGnZdUNb1-Msb10NBypG2cQm+5JrN-Ajv8VNvmX2+Pg@mail.gmail.com>
Date:	Thu, 29 Nov 2012 11:52:03 -0600
From:	Steve French <smfrench@...il.com>
To:	Jesper Nilsson <jesper.nilsson@...s.com>
Cc:	linux-cifs@...r.kernel.org, sfrench@...ba.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFQ PATCH] cifs: Change default security error message

This has already been changed in the cifs-2.6.git for-next  branch.
We had run into problems with Apple Server with ntlmv2 so it took
longer than expected to test it, and it was too late for 3.7 so the
patch to move to ntlmssp encapsulated ntlmv2 which removes this
warning is in cifs-2.6.git and queued for 3.8

On Thu, Nov 29, 2012 at 11:30 AM, Jesper Nilsson
<jesper.nilsson@...s.com> wrote:
> Hi!
>
> Connecting with a default security mechanism prompts an KERN_ERROR
> output warning to the user that the default mechanism will be changed
> in Linux 3.3.
>
> We're now at 3.7, so we either could remove the warning completely
> (if the default has been changed), or we could bump the number to
> what our current target for the change is.
>
>
> The below patch changes the cERROR (which turns into a printk with KERN_ERROR)
> into a straight printk with KERN_WARNING and changes the text to indicate
> that it was changed in 3.3.
>
> I expect that the patch is incorrect and that we should choose
> another of the alternative solutions above, but I'd like to get
> some input on this.
>
> Not-Signed-off-by: Jesper Nilsson <jesper.nilsson@...s.com>
> ---
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index c83f5b65..968456f 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2480,9 +2480,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
>         supported for many years, time to update default security mechanism */
>         if ((volume_info->secFlg == 0) && warned_on_ntlm == false) {
>                 warned_on_ntlm = true;
> -               cERROR(1, "default security mechanism requested.  The default "
> -                       "security mechanism will be upgraded from ntlm to "
> -                       "ntlmv2 in kernel release 3.3");
> +               printk(KERN_WARNING "default security mechanism requested.  "
> +                       "The default security mechanism was changed "
> +                       " from ntlm to ntlmv2 in kernel release 3.3");
>         }
>         ses->overrideSecFlg = volume_info->secFlg;
>
>
>
> /^JN - Jesper Nilsson
> --
>                Jesper Nilsson -- jesper.nilsson@...s.com
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Thanks,

Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/