linux-kernel - Re: [PATCH 1/2] mfd: tps65910: remove unused data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50B7B52A.30005@nvidia.com>
Date:	Fri, 30 Nov 2012 00:49:06 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	"Kim, Milo" <Milo.Kim@...com>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] mfd: tps65910: remove unused data

On Thursday 29 November 2012 02:18 PM, Kim, Milo wrote:
>   The 'io_mutex' is not used anywhere.
>   The regmap API supports the mutex internally, so no additional mutex required.
>
>   And 'domain' private data is unnecessary because the irq domain is
>   already registered by using regmap_add_irq_chip().
>
> Signed-off-by: Milo(Woogyom) Kim<milo.kim@...com>
> ---

Thanks, I missed on my cleanups.

Acked-by: Laxman Dewangan <ldewangan@...dia.com>
>   drivers/mfd/tps65910.c       |    1 -
>   include/linux/mfd/tps65910.h |    2 --
>   2 files changed, 3 deletions(-)
>
> diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
> index fdb3027..d5ef3a5 100644
> --- a/drivers/mfd/tps65910.c
> +++ b/drivers/mfd/tps65910.c
> @@ -486,7 +486,6 @@ static __devinit int tps65910_i2c_probe(struct i2c_client *i2c,
>   	tps65910->dev =&i2c->dev;
>   	tps65910->i2c_client = i2c;
>   	tps65910->id = chip_id;
> -	mutex_init(&tps65910->io_mutex);
>
>   	tps65910->regmap = devm_regmap_init_i2c(i2c,&tps65910_regmap_config);
>   	if (IS_ERR(tps65910->regmap)) {
> diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h
> index 0b16903..20e433e 100644
> --- a/include/linux/mfd/tps65910.h
> +++ b/include/linux/mfd/tps65910.h
> @@ -893,7 +893,6 @@ struct tps65910 {
>   	struct device *dev;
>   	struct i2c_client *i2c_client;
>   	struct regmap *regmap;
> -	struct mutex io_mutex;
>   	unsigned int id;
>
>   	/* Client devices */
> @@ -907,7 +906,6 @@ struct tps65910 {
>   	/* IRQ Handling */
>   	int chip_irq;
>   	struct regmap_irq_chip_data *irq_data;
> -	struct irq_domain *domain;
>   };
>
>   struct tps65910_platform_data {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/