| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Nov 2012 21:10:26 +0100 From: Robert Jarzmik <robert.jarzmik@...e.fr> To: Chao Xie <chao.xie@...vell.com> Cc: a.zummo@...ertech.it, rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org, haojian.zhuang@...il.com, linux-arm-kernel@...ts.infradead.org, xiechao.mail@...il.com Subject: Re: [PATCH 4/4] rtc: pxa: request rtc irqs when probe/remove the device Chao Xie <chao.xie@...vell.com> writes: > The original pxa_rtc_open/pxa_rtc_release will be called > when the /dev/rtc0 is opened or closed. > In fact, these two functions will register/unregister the irqs. > User application will use /dev/rtc0 to read the rtc time or set > the alarm. The rtc should still run indepent of open/close the > rtc device. > So only register the irqs when probe the device, > and disable clock and unregister the irqs when remove the device. No, as Russell I think that's not correct. This is not how RTC API should be used. And on top of RTC API considerations, consider this : today, rtc-pxa and rtc-sa1100 _can_ coexist on a PXA platform, and be used alternatively (I know, it's a bit borderline because of IO space, but anyway it does work). How will that be possible with your patch ? Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists