linux-kernel - Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50B87082.3020604@broadcom.com>
Date:	Fri, 30 Nov 2012 09:38:26 +0100
From:	"Arend van Spriel" <arend@...adcom.com>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	backports@...r.kernel.org, alexander.stein@...tec-electronic.com,
	brudley@...adcom.com, rvossen@...adcom.com, frankyl@...adcom.com,
	kanyan@...adcom.com, linux-wireless@...r.kernel.org,
	brcm80211-dev-list@...adcom.com, kyungmin.park@...sung.com,
	s.nawrocki@...sung.com, linux-arm-kernel@...ts.infradead.org,
	linux-media@...r.kernel.org, daniel.vetter@...ll.ch,
	intel-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	srinidhi.kasagar@...ricsson.com, linus.walleij@...aro.org,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

On 11/29/2012 09:45 PM, Luis R. Rodriguez wrote:
> From: "Luis R. Rodriguez" <mcgrof@...not-panic.com>
> 
> Turns out a few drivers have strayed away from using the
> spinlock_t typedef and decided to use struct spinlock
> directly. This series converts these drivers to use
> spinlock_t. Each change has been compile tested with
> allmodconfig and sparse checked. Driver developers
> may want to look at the compile error output / sparse
> error report supplied in each commit log, in particular
> brcmfmac and i915, there are quite a few things that
> are not related to this change that the developers
> can clean up / fix.

So what is the rationale here. During mainlining our drivers we had to
remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle
(chapter 5 Typedefs) is spending a number of lines explaining why.

So is spinlock_t an exception to this rule simply because the kernel
uses spinlock_t all over the place. Using Greg's favorite final email
remark:

Confused.

Gr. AvS

> Luis R. Rodriguez (6):
>   ux500: convert struct spinlock to spinlock_t
>   i915: convert struct spinlock to spinlock_t
>   s5p-fimc: convert struct spinlock to spinlock_t
>   s5p-jpeg: convert struct spinlock to spinlock_t
>   brcmfmac: convert struct spinlock to spinlock_t
>   ie6xx_wdt: convert struct spinlock to spinlock_t
> 
>  drivers/crypto/ux500/cryp/cryp.h               |    4 ++--
>  drivers/crypto/ux500/hash/hash_alg.h           |    4 ++--
>  drivers/gpu/drm/i915/i915_drv.h                |    4 ++--
>  drivers/media/platform/s5p-fimc/mipi-csis.c    |    2 +-
>  drivers/media/platform/s5p-jpeg/jpeg-core.h    |    2 +-
>  drivers/net/wireless/brcm80211/brcmfmac/fweh.h |    2 +-
>  drivers/watchdog/ie6xx_wdt.c                   |    2 +-
>  7 files changed, 10 insertions(+), 10 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/