linux-kernel - RE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1d7701cdceeb$0c441fc0$24cc5f40$%kim@samsung.com>
Date:	Fri, 30 Nov 2012 20:08:38 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Olof Johansson' <olof@...om.net>,
	'Doug Anderson' <dianders@...omium.org>
Cc:	'Arnd Bergmann' <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org,
	linux-samsung-soc@...r.kernel.org,
	'Russell King' <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] ARM: EXYNOS: Avoid early use of of_machine_is_compatible()

Olof Johansson wrote:
> 
> On Wed, Nov 28, 2012 at 8:16 AM, Doug Anderson <dianders@...omium.org>
> wrote:
> > Olof / Kukjin,
> >

[...]

> >>
> >> I really don't like splitting an if/else with an ifdef like this, it's
> fragile
> >> code and can be hard to follow.
> >
> > Agree.

Definitely, same here ;-)

> >> There's also a second build error with exynos_defconfig in the
> >> exynos5-dt.c board file due to a missing include. Teaches me to just
> apply
> >> patches without trying to build. :(
> >
> > In the tree I was testing against (the arm-soc/for-next branch at
> > 659b19ca3a77e2ac32fe84d95242653c75dd07c7) I see the include file in
> > the exynos5-dt.c file already.  In my tree it was added by "2eae613b:
> > ARM: EXYNOS: Add MFC device tree support".
> >
> > Your patch applies cleanly on mine but I end up with:
> >
> >   #include <linux/of_platform.h>
> >   #include <linux/of_fdt.h>
> >   #include <linux/serial_core.h>
> >   #include <linux/io.h>
> >   #include <linux/memblock.h>
> >   #include <linux/of_fdt.h>
> 
> Sigh, this is because people add includes out of alphabetical order.

Yeah.

> We'll just have to fix it up later, 

Sure, I will after release 3.8-rc1.

[...]
> 
> I've pushed out the branch with the patch applied (with the above
changed).
> 
Thanks for your fix.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/