linux-kernel - Re: [PATCH] mfd: da9052-core: Fix interrupts reported to mfd child devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121130111614.GA1729@sortiz-mobl>
Date:	Fri, 30 Nov 2012 12:16:14 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Philipp Zabel <p.zabel@...gutronix.de>,
	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: da9052-core: Fix interrupts reported to mfd child
 devices

Hi Philipp,

On Fri, Nov 30, 2012 at 12:04:38PM +0100, Samuel Ortiz wrote:
> Hi Philipp,
> 
> On Thu, Nov 29, 2012 at 04:04:28PM +0100, Philipp Zabel wrote:
> > The patch "mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe"
> > replaces the irq_base with the da9052_map_irq function but doesn't
> > update the irq_base parameter to the mfd_add_devices call.
> > This causes child devices to try and request IRQs with just the internal
> > offset number.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@...gutronix.de>
> > ---
> >  drivers/mfd/da9052-core.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> Applied, 
I'll take that back. It fails to build because on my for-next branch
da9052_map_irq() is a da9052-irq.c static function. It was moved from core.c
to irq.c with Fabio's patch "mfd: da9052: Introduce da9052-irq.c", commit
8bad1abd6303476d6f77878aa8ea737d5d1b625c.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/