lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Nov 2012 14:04:12 +0100 From: Stefan Hajnoczi <stefanha@...il.com> To: Laurent Navet <laurent.navet@...il.com> Cc: devel@...verdev.osuosl.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "line6linux-devel@...ts.sourceforge.net" <line6linux-devel@...ts.sourceforge.net>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues On Fri, Nov 30, 2012 at 11:57 AM, Laurent Navet <laurent.navet@...il.com> wrote: > fix those checkpatch issues > drivers/staging/line6/pcm.c:84: > WARNING: simple_strtoul is obsolete, use kstrtoul instead > call to obsolete simple_strtoul() replaced by kstrtoint() > > drivers/staging/line6/pcm.c:423: > ERROR: switch and case should be at the same indent > realigns comments > > Signed-off-by: Laurent Navet <laurent.navet@...il.com> > --- > drivers/staging/line6/pcm.c | 30 ++++++++++++++++++------------ > 1 file changed, 18 insertions(+), 12 deletions(-) Changes are fine. In the future, please split changes into individual patches. For example: Patch 1 - Rename 'rv' to 'ret' Patch 2 - Replace decprecated simple_strtoul() with kstrtoint() in pcm_set_impulse_period() Patch 3 - Realign comment in line6_init_pcm() switch statement Keeping patches focussed on doing just one thing makes it easier to revert, bisect, and review them. Reviewed-by: Stefan Hajnoczi <stefanha@...il.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists