linux-kernel - Re: [PATCH v2 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <50B8D069.8070608@gmail.com>
Date:	Fri, 30 Nov 2012 17:27:37 +0200
From:	Eli Billauer <eli.billauer@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH v2 2/2] New driver: Xillybus generic interface for FPGA
 (programmable logic)

I made changes in the code as a response to almost all your comments to 
my best understanding.

I also sent a separate mail responding to a couple of issues, which 
seems not have reached you.

But to put it short:

* The pci_ids: I wasn't sure if I should remove only my own product ID 
or all the vendor IDs, and this is clear now.

* As for the documentation, I don't quite understand what I should add. 
There's a rather extensive documentation for download at the site. The 
docs for the host side mostly instruct common UNIX programming 
techniques: The device files are just data pipes to FIFOs in the FPGA, 
behaving like one would expect.

* As for the special class issue: When Xillybus is used, the whole 
system's mission is usually around it (e.g. it's a computer doing data 
acquisition through the Xillybus pipes). So giving it a high profile 
makes sense, I believe. Besides, a dozen of device files are not rare. 
Needless to say, I'm not going to insist on this.

Other than that, it's all changes in the code. It's a major change there.

Sorry for this miscommunication.

   Eli

On 11/30/2012 05:09 PM, Greg KH wrote:
> You didn't answer my previous comments about the kernel/user interface
> here, why not?
>
> And you ignored my other review comments, which is a sure way for me to
> want to reject this and not look at any future submissions from you for
> at least a month...
>
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/