linux-kernel - Re: [PATCH] bonding: rlb mode of bond should not alter ARP originating via bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121130.120813.1360888707923955813.davem@davemloft.net>
Date:	Fri, 30 Nov 2012 12:08:13 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	zheng.x.li@...cle.com, netdev@...r.kernel.org, andy@...yhouse.net,
	linux-kernel@...r.kernel.org, joe.jin@...cle.com
Subject: Re: [PATCH] bonding: rlb mode of bond should not alter ARP
 originating via bridge

From: Jay Vosburgh <fubar@...ibm.com>
Date: Thu, 29 Nov 2012 10:28:25 -0800

> Zheng Li <zheng.x.li@...cle.com> wrote:
> 
>>Do not modify or load balance ARP packets passing through balance-alb
>>mode (wherein the ARP did not originate locally, and arrived via a bridge).
>>
>>Modifying pass-through ARP replies causes an incorrect MAC address 
>>to be placed into the ARP packet, rendering peers unable to communicate 
>>with the actual destination from which the ARP reply originated.
>>
>>Load balancing pass-through ARP requests causes an entry to be
>>created for the peer in the rlb table, and bond_alb_monitor will
>>occasionally issue ARP updates to all peers in the table instrucing them
>>as to which MAC address they should communicate with; this occurs when
>>some event sets rx_ntt.  In the bridged case, however, the MAC address
>>used for the update would be the MAC of the slave, not the actual source
>>MAC of the originating destination.  This would render peers unable to
>>communicate with the destinations beyond the bridge.
>>
>>Signed-off-by: Zheng Li <zheng.x.li@...cle.com>
>>Cc: Jay Vosburgh <fubar@...ibm.com>
>>Cc: Andy Gospodarek <andy@...yhouse.net>
>>Cc: "David S. Miller" <davem@...emloft.net>
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/