| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Nov 2012 18:08:48 -0800 From: Greg KH <gregkh@...uxfoundation.org> To: "Laurent Navet [Mali]" <laurent.navet@...il.com> Cc: devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: line6: Fix checkpatch.pl switch - case issue On Thu, Nov 29, 2012 at 12:21:22PM +0100, Laurent Navet [Mali] wrote: > From: "Laurent Navet [Mali]" <laurent.navet@...il.com> > > delete old commentted code to avoid this checkpatch error : > line6/pcm.c:423: ERROR: switch and case should be at the same indent > > Signed-off-by: Laurent Navet [Mali] <laurent.navet@...il.com> What is the [Mali] thing for? > --- > drivers/staging/line6/pcm.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c > index 6c1e313..a0ce781 100644 > --- a/drivers/staging/line6/pcm.c > +++ b/drivers/staging/line6/pcm.c > @@ -455,14 +455,6 @@ int line6_init_pcm(struct usb_line6 *line6, > ep_write = 0x01; > break; > > - /* this is for interface_number == 1: > - case LINE6_DEVID_TONEPORT_UX2: > - case LINE6_DEVID_PODSTUDIO_UX2: > - ep_read = 0x87; > - ep_write = 0x00; > - break; > - */ Why not properly indent it to keep the comment around instead? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists