linux-kernel - Re: [PATCH] staging/serqt_usb2: Refactor qt_status_change_check() in serqt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121130021026.GB2056@kroah.com>
Date:	Thu, 29 Nov 2012 18:10:26 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	YAMANE Toshiaki <yamanetoshi@...il.com>
Cc:	Joe Perches <joe@...ches.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] staging/serqt_usb2: Refactor qt_status_change_check() in
 serqt_usb2.c

On Thu, Nov 29, 2012 at 01:57:56PM +0900, YAMANE Toshiaki wrote:
> Improved position to increment variable i,
> And typo fixes.
> 
> Signed-off-by: YAMANE Toshiaki <yamanetoshi@...il.com>
> ---
>  drivers/staging/serqt_usb2/serqt_usb2.c |   12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
> index 1b3e995..095d6f2 100644
> --- a/drivers/staging/serqt_usb2/serqt_usb2.c
> +++ b/drivers/staging/serqt_usb2/serqt_usb2.c
> @@ -309,26 +309,26 @@ static void qt_status_change_check(struct tty_struct *tty,
>  			case 0x00:
>  				if (i > (RxCount - 4)) {
>  					dev_dbg(&port->dev,
> -						"Illegal escape seuences in received data\n");
> +						"Illegal escape sequence in received data\n");

This is a different type of fix from:

>  					break;
>  				}
>  
> -				ProcessLineStatus(qt_port, data[i + 3]);
> -
>  				i += 3;
> +				ProcessLineStatus(qt_port, data[i]);

I think you just changed the logic in this function, didn't you?

> +
>  				flag = 1;
>  				break;
>  
>  			case 0x01:
>  				if (i > (RxCount - 4)) {
>  					dev_dbg(&port->dev,
> -						"Illegal escape seuences in received data\n");
> +						"Illegal escape sequence in received data\n");
>  					break;
>  				}
>  
> -				ProcessModemStatus(qt_port, data[i + 3]);
> -
>  				i += 3;
> +				ProcessModemStatus(qt_port, data[i]);

Same here, what happens to i after this?

Please break into two patches, and verify that you didn't break anything
here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/