linux-kernel - Re: [PATCH 1/2] init.h: Remove _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121130204736.GB32483@kroah.com>
Date:	Fri, 30 Nov 2012 12:47:36 -0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jim Cromie <jim.cromie@...il.com>,
	Borislav Petkov <borislav.petkov@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>, Michal Marek <mmarek@...e.cz>,
	Tony Lindgren <tony@...mide.com>,
	Jonathan Kliegman <kliegs@...omium.org>,
	Chris Zankel <chris@...kel.net>,
	Bill Pemberton <wfp5p@...idian.itc.virginia.edu>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Sam Ravnborg <sam@...nborg.org>,
	linux-kbuild <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH 1/2] init.h: Remove __dev* sections from the kernel

On Fri, Nov 30, 2012 at 12:39:43PM -0800, H. Peter Anvin wrote:
> On 11/29/2012 10:43 AM, Greg Kroah-Hartman wrote:
> >
> >-/* Used for HOTPLUG */
> >-#define __devinit        __section(.devinit.text) __cold notrace
> >-#define __devinitdata    __section(.devinit.data)
> >-#define __devinitconst   __constsection(.devinit.rodata)
> >-#define __devexit        __section(.devexit.text) __exitused __cold notrace
> >-#define __devexitdata    __section(.devexit.data)
> >-#define __devexitconst   __constsection(.devexit.rodata)
> >+/* Used for HOTPLUG, but that is always enabled now, so just make them noops */
> >+#define __devinit
> >+#define __devinitdata
> >+#define __devinitconst
> >+#define __devexit
> >+#define __devexitdata
> >+#define __devexitconst
> >
> 
> Second question... what about the __exitused __cold notrace annotations?

__exitused shouldn't matter, we shouldn't be optimizing these away at
all anymore.  I don't know about __cold and notrace, but given that
these could be traced, I don't see why that marking got there in the
first place.

In reading compiler-gcc4.h, and knowing just how infrequent these
functions are ever called, I would be amazed if the __cold marking ever
even helped anything out here.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/