linux-kernel - Re: Bisected regression: iterate_fd() selinux change affects flash plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121130040240.GC4939@ZenIV.linux.org.uk>
Date:	Fri, 30 Nov 2012 04:02:40 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Eric Paris <eparis@...isplace.org>
Cc:	Pavel Roskin <proski@....org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	SE-Linux <selinux@...ho.nsa.gov>
Subject: Re: Bisected regression: iterate_fd() selinux change affects flash
 plugin

On Fri, Nov 30, 2012 at 03:40:34AM +0000, Al Viro wrote:

> The bug is real, but Pavel's patch is all wrong.  The problem is in the
> argument; we should pass descriptor number, not descriptor + 1.  And fixing
> that (in iterator_fd() itself) makes all callbacks work as they ought to.
> 
> PS: Pavel, the life is painful enough as it is, no need to involve BZ into
> it.  Next time you need to post a patch, please do just that, especially
> when it's so short, OK?

See tonight's vfs.git#for-linus; the head is at commit a77cfcb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/