linux-kernel - Re: [PATCH] lxdialog:inputbox: Fix can't change selected button with Left/Right when input box selected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201212021832.44326.yann.morin.1998@free.fr>
Date:	Sun, 2 Dec 2012 18:32:43 +0100
From:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
To:	linux-kbuild@...r.kernel.org
Cc:	Wang YanQing <udknight@...il.com>, mmarek@...e.cz,
	linux-kernel@...r.kernel.org, rdunlap@...otime.net, bp@...en8.de,
	sakiwit@...il.com, lacombar@...il.com,
	lucas.demarchi@...fusion.mobi, dave@....org,
	paul.gortmaker@...driver.com, crquan@...il.com, bpoirier@...e.de
Subject: Re: [PATCH] lxdialog:inputbox: Fix can't change selected button with Left/Right when input box selected

Wang, All,

On Sunday 02 December 2012 Wang YanQing wrote:
> inputbox code don't support use Left/Right to change input
> position in the input box, so it use continue to skip them
> when input key is Left/Right, but use break for Up/Down, so
> we can change selected button with Up/Down but we can't do it
> with Left/Right key when input box selected.
> This patch fix it.

Although I do understand the motivation behind your change, may I suggest
that left/right are used to navigate *inside* the input field, so it is
possible to modify the text in place?

The nconf frontend allows editing text in place, so I find it disturbing
not to be able to do it in mconf.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/