linux-kernel - Re: [PATCH -next] f2fs: remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 03 Dec 2012 08:12:22 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH -next] f2fs: remove unused variable

Merged.
Thanks,

Add CC: linux-f2fs-devel@...ts.sourceforge.net

2012-12-02 (일), 08:11 -0500, Wei Yongjun:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> The variables node_page and page_offset are initialized but never used
> otherwise, so remove those unused variables.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  fs/f2fs/file.c | 2 --
>  fs/f2fs/dir.c  | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index f5ae36d..69e05c6 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -30,7 +30,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
>  	struct page *page = vmf->page;
>  	struct inode *inode = vma->vm_file->f_path.dentry->d_inode;
>  	struct f2fs_sb_info *sbi = F2FS_SB(inode->i_sb);
> -	struct page *node_page;
>  	block_t old_blk_addr;
>  	struct dnode_of_data dn;
>  	int err;
> @@ -50,7 +49,6 @@ static int f2fs_vm_page_mkwrite(struct vm_area_struct *vma,
>  	}
>  
>  	old_blk_addr = dn.data_blkaddr;
> -	node_page = dn.node_page;
>  
>  	if (old_blk_addr == NULL_ADDR) {
>  		err = reserve_new_block(&dn);
> 
> diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c
> index 5975568..6891e45 100644
> --- a/fs/f2fs/dir.c
> +++ b/fs/f2fs/dir.c
> @@ -509,13 +509,11 @@ void f2fs_delete_entry(struct f2fs_dir_entry *dentry, struct page *page,
>  	}
>  
>  	if (bit_pos == NR_DENTRY_IN_BLOCK) {
> -		loff_t page_offset;
>  		truncate_hole(dir, page->index, page->index + 1);
>  		clear_page_dirty_for_io(page);
>  		ClearPageUptodate(page);
>  		dec_page_count(sbi, F2FS_DIRTY_DENTS);
>  		inode_dec_dirty_dents(dir);
> -		page_offset = page->index << PAGE_CACHE_SHIFT;
>  		f2fs_put_page(page, 1);
>  	} else {
>  		f2fs_put_page(page, 1);
> 
> 

-- 
Jaegeuk Kim
Samsung

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)