| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121203094828.GA14363@n2100.arm.linux.org.uk> Date: Mon, 3 Dec 2012 09:48:29 +0000 From: Russell King - ARM Linux <linux@....linux.org.uk> To: Chao Xie <xiechao.mail@...il.com> Cc: Haojian Zhuang <haojian.zhuang@...il.com>, Chao Xie <chao.xie@...vell.com>, Alessandro Zummo <a.zummo@...ertech.it>, rtc-linux@...glegroups.com, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 1/4] rtc: sa1100: enable/disable rtc when probe/remove the device On Mon, Dec 03, 2012 at 10:53:07AM +0800, Chao Xie wrote: > I want to correct what i said. For the irq register/unregister i think > can be done at open/release. But for clock enable/disable, i do not > think so. If clock is disabled, as i think RTC will not work. User API > still use open->get_time->close for "date" command. It means that RTC > will not return correct date to user. "I think" is not good enough for patches like this. Please test it. On SA11x0 and PXA platforms, the clock for the sa1100-rtc is a dummy clock; it has no effect. For MMP, I don't have access to the TRMs so that's something you're going to have to find out. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists