linux-kernel - Re: [PATCH] tools:virtio: fix compilation warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121203110106.GB26167@redhat.com>
Date:	Mon, 3 Dec 2012 13:01:06 +0200
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Cong Ding <dinggnu@...il.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	Christoph Hellwig <hch@....de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tools:virtio: fix compilation warning

On Mon, Dec 03, 2012 at 10:24:54AM +0000, Cong Ding wrote:
> We do not allow old-style function definition.  Always spell foo(void) if
> a function does not take any parameters.
> 
> Signed-off-by: Cong Ding <dinggnu@...il.com>

Thanks, applied.

> ---
>  tools/virtio/virtio_test.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index e626fa5..6d25dcd 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -232,7 +232,7 @@ const struct option longopts[] = {
>  	}
>  };
>  
> -static void help()
> +static void help(void)
>  {
>  	fprintf(stderr, "Usage: virtio_test [--help]"
>  		" [--no-indirect]"
> -- 
> 1.7.4.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/