| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1354543290.7030.26.camel@deadeye.wl.decadent.org.uk> Date: Mon, 3 Dec 2012 14:01:30 +0000 From: Ben Hutchings <bhutchings@...arflare.com> To: Nicolas Ferre <nicolas.ferre@...el.com> CC: "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, Joachim Eastwood <manabian@...il.com>, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com> Subject: Re: [PATCH] net/macb: Use dmapool to align descriptors on 64bits On Mon, 2012-12-03 at 13:15 +0100, Nicolas Ferre wrote: > Depending on datapath, some revisions of GEM need > 64bits aligned descriptors. Use dmapool to allocate > these descriptors. > Note that different size between RX and TX rings > leads to the creation of two pools. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com> [...] dma_alloc_coherent() allocates whole pages, which I think is quite enough alignment. You can't save memory by doing this, since each pool needs at least one page. So what is this change meant to achieve? Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists