linux-kernel - Re: [RFC PATCH] staging, android, ashmem: invalidate pin/unpin ioctl for private map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAmzW4PFKjJ-TmRG0ee4P9OsJwfje_vNS7mbm_iS0+nXpbdBbQ@mail.gmail.com>
Date:	Mon, 3 Dec 2012 23:52:15 +0900
From:	JoonSoo Kim <js1304@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	devel@...verdev.osuosl.org, Robert Love <rlove@...gle.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Colin Cross <ccross@...roid.com>, linux-kernel@...r.kernel.org,
	Dima Zavin <dima@...roid.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Brian Swetland <swetland@...gle.com>,
	Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [RFC PATCH] staging, android, ashmem: invalidate pin/unpin ioctl
 for private map

2012/12/3 Dan Carpenter <dan.carpenter@...cle.com>:
> On Mon, Dec 03, 2012 at 09:09:59AM +0900, JoonSoo Kim wrote:
>> Hello, Dan.
>>
>> 2012/12/2 Dan Carpenter <dan.carpenter@...cle.com>:
>> > On Sat, Dec 01, 2012 at 02:45:57AM +0900, Joonsoo Kim wrote:
>> >> @@ -614,21 +616,35 @@ static int ashmem_pin_unpin(struct ashmem_area *asma, unsigned long cmd,
>> >>       pgstart = pin.offset / PAGE_SIZE;
>> >>       pgend = pgstart + (pin.len / PAGE_SIZE) - 1;
>> >>
>> >> -     mutex_lock(&ashmem_mutex);
>> >> +     if (asma->shared_mapping) {
>> >> +             mutex_lock(&ashmem_mutex);
>> >
>> > Wouldn't we need to hold the mutex while we check the
>> > ->shared_mapping?
>>
>> I doesn't fully understand ashmem's lock semantic.
>> Code for retrieving some value of asma instance doesn't hold the mutex, now.
>> For example, in ashmem_ioctl(), asma->size, asma->prot_mask.
>> And in ashmem_pin_unpin(), there is asma->file, asma->size which is
>> retrieved without the mutex.
>> According to this semantic, the mutex doesn't need for checking
>> asma->shared_mapping.
>
> The ashmem_ioctl() is clearly racy.  :P  asma->size can be modified
> and read at the same time.  It's not an example to follow.

Okay :)
I will insert a code for holding the mutex in next spin.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/