[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <50BCD5CB.2030506@suse.cz>
Date: Mon, 03 Dec 2012 17:39:39 +0100
From: Michal Marek <mmarek@...e.cz>
To: Joonsoo Kim <js1304@...il.com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] scripts/tags.sh: Support compiled source
On 3.12.2012 17:22, Joonsoo Kim wrote:
> We usually have interst in compiled files only,
> because they are strongly related to individual's work.
> Current tags.sh can't select compiled files, so support it.
>
> We can use this functionality like below.
> "make cscope O=. SRCARCH=xxxx SUBARCH=compiled"
I like the idea, but please try to come up with a different syntax that
does not abuse SUBARCH.
> +all_compiled_sources()
> +{
> + for i in $(all_sources); do
> + if [[ $i =~ .*c$ || $i =~ .*S$ ]]; then
> + j=${i/\.[cS]/\.o}
Please use 'case "$i" in ...' instead of the bash-specific [[ ... ]]
construct.
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists