linux-kernel - Re: [PATCH] net: phy: smsc: force all capable mode if the phy is started in powerdown mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121203.133445.1850294260156519269.davem@davemloft.net>
Date:	Mon, 03 Dec 2012 13:34:45 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	tremyfr@...oo.fr
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	otavio@...ystems.com.br, javier@...hile0.org, jkosina@...e.cz,
	eric.jarrige@...adeus.org, julien.boibessot@...adeus.com,
	thomas.petazzoni@...e-electrons.com
Subject: Re: [PATCH] net: phy: smsc: force all capable mode if the phy is
 started in powerdown mode

From: Philippe Reynes <tremyfr@...oo.fr>
Date: Sat,  1 Dec 2012 21:44:49 +0100

>  static int smsc_phy_config_init(struct phy_device *phydev)
>  {
> -	int rc = phy_read(phydev, MII_LAN83C185_CTRL_STATUS);
> +	/*
> +	 * If the SMSC PHY is in power down mode, then set it
> +	 * in all capable mode before using it.
> +	 */
> +	int rc = phy_read(phydev, MII_LAN83C185_SPECIAL_MODES);

This is formatted poorly.  Do not put comments above the basic
block variable declarations, it looks terrible.

Also, comments in the networking code should be formatted:

	/* Like
	 * this.
	 */

	/*
	 * Not like
	 * this.
	 */

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/