linux-kernel - RE: [PATCH v4 1/3] aerdrv: Trace Event for AER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A961433CDFF2F640A2866803152E61F9516EE70A@G4W3218.americas.hpqcorp.net>
Date:	Mon, 3 Dec 2012 19:58:16 +0000
From:	"Ortiz, Lance E" <lance.oritz@...com>
To:	Borislav Petkov <bp@...en8.de>
CC:	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"lance_ortiz@...mail.com" <lance_ortiz@...mail.com>,
	"jiang.liu@...wei.com" <jiang.liu@...wei.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"mchehab@...hat.com" <mchehab@...hat.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v4 1/3] aerdrv: Trace Event for AER

> > +/*
> > + * PCIe Advanced Error Reporting (AER) PCIE Report Error
> 
> Why do you insist on keeping this convoluted compound name? What does
> "PCIe AER PCIe Report Error" even mean?
> 
> This is not unreadable technical documentation but something people
> should actually understand. And it is simply a PCIe AER tracepoint. So
> why the h*ll not call it by its real name?

I will fix that.

> 
> > + *
> > + * These events are generated when hardware detects a corrected or
> > + * uncorrected event on a pci express device. The event report has
> 
> And you should stick to the same spelling for PCIe throughout the text,
> so choose one and use it everywhere.
> 
Ok

> 
> Also, you haven't addressed Mauro's comment about other bits in the
> spec
> which are not here. Why are you skipping them?

I missed that mail. I will address that.

Lance