lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 2 Dec 2012 23:36:36 -0800 From: Dmitry Torokhov <dmitry.torokhov@...il.com> To: Kamal Mostafa <kamal@...onical.com> Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, Henrik Rydberg <rydberg@...omail.se>, David Solda <dso@...ress.com>, Troy Abercrombia <ta@...ress.com>, Dudley Du <dudl@...ress.com>, Cypress Semiconductor Corporation <customercare@...ress.com>, Kyle Fazzari <git@...tus.e4ward.com>, Mario Limonciello <mario_limonciello@...l.com>, Tim Gardner <tim.gardner@...onical.com>, Herton Krzesinski <herton.krzesinski@...onical.com> Subject: Re: [PATCH v3 0/4] Cypress PS/2 Trackpad driver Hi Kamal, On Thu, Nov 29, 2012 at 01:57:57PM -0800, Kamal Mostafa wrote: > This driver, submitted on behalf of Cypress Semiconductor Corporation and > additional contributors, provides support for the Cypress PS/2 Trackpad. > > This [PATCH v3] version differs from my previous submitted version[1]: > > Patch #1 (cmdbuf to 8 bytes) and #3 (link in driver) are unchanged. > > Patch #2 (main driver), as recommended by Henrik Rydberg[2]: > - use input_mt_assign_slots; drop cypress_cal_finger_id. > - enable 2-finger-only SEMI_MT; drop cypress_simulate_fingers. > - various code clean-ups. > > Henrik, does patch #2 appear to properly use assign_slots and SEMI_MT as > you intended? This SEMI_MT method does work (with 2 finger support only), > but I'm not clear why we wouldn't want to handle >2 fingers also, so ... > > Patch #4 (new) reintroduces simulated multitouch for up to 5 fingers > (#if CYPRESS_SIMULATE_MT), disabling SEMI_MT again. > > If that functionality (support for >2 fingers) can be acheived in some > better way, please advise. You can still report true number of fingers on the pad via BTN_TOOL_*TAP while reporting the bounding box, the same way as Synaptics, Elantech, ALPS and Sentelic drivers are doing it. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists