linux-kernel - Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <xa1tsj7m3qza.fsf@mina86.com>
Date:	Tue, 04 Dec 2012 14:07:53 +0100
From:	Michal Nazarewicz <mina86@...a86.com>
To:	Santosh Shilimkar <santosh.shilimkar@...com>,
	Vitaly Andrianov <vitalya@...com>
Cc:	m.szyprowski@...sung.com, kyungmin.park@...sung.com, arnd@...db.de,
	linux-kernel@...r.kernel.org, linux-keystone@...t.ti.com,
	Cyril Chemparathy <cyril@...com>
Subject: Re: [linux-keystone] [PATCH v2] drivers: cma: fix addressing on PAE machines

> On Monday 03 December 2012 09:16 PM, Vitaly Andrianov wrote:
>> This patch fixes a couple of bugs that otherwise impair CMA functionality on
>> PAE machines:
>>
>>    - alignment must be a 64-bit type when running on systems with 64-bit
>>      physical addresses.  If this is not the case, the limit calculation thunks
>>      allocations down to an address range < 4G.
>>
>>    - The allocated range check is removed. On 32bit ARM kernel with LPAE
>>      enabled the base may be allocated outside the fist 4GB of physical
>>      memory (keystone SoC for example).

On Tue, Dec 04 2012, Santosh Shilimkar wrote:
> Any reason you have clubbed two fixes in one patch. Its better to keep
> the two fixes separate patches.

They are all related to the very same issue, and what the whole patch
does is change the type used to store physical addresses from unsigned
long to phys_addr_t.  This is really a single change.

>> Signed-off-by: Vitaly Andrianov <vitalya@...com>
>> Signed-off-by: Cyril Chemparathy <cyril@...com>

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@...gle.com>--------------ooO--(_)--Ooo--

Content of type "application/pgp-signature" skipped