linux-kernel - Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 04 Dec 2012 18:17:28 +0000
From:	David Howells <dhowells@...hat.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	rusty@...abs.org, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH 2/3] MODSIGN: Avoid using .incbin in C source

Michal Marek <mmarek@...e.cz> wrote:

> Using the asm .incbin statement in C sources breaks any gcc wrapper which
> assumes that preprocessed C source is self-contained. Use a separate .S
> file to include the siging key and certificate.

I was trying to avoid that as .S files generally don't crop up in generic
code and the format of the assembly varies with the arch.  However, you don't
seem to have anything that should cause a problem - so:

Acked-by: David Howells <dhowells@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/