linux-kernel - RE: [PATCH v6 3/3] aerdrv: Cleanup log output for CPER based AER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A961433CDFF2F640A2866803152E61F9516EEAB4@G4W3218.americas.hpqcorp.net>
Date:	Tue, 4 Dec 2012 20:06:48 +0000
From:	"Ortiz, Lance E" <lance.oritz@...com>
To:	Joe Perches <joe@...ches.com>
CC:	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"lance_ortiz@...mail.com" <lance_ortiz@...mail.com>,
	"jiang.liu@...wei.com" <jiang.liu@...wei.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"bp@...en8.de" <bp@...en8.de>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"mchehab@...hat.com" <mchehab@...hat.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 3/3] aerdrv: Cleanup log output for CPER based AER

> Hi again Lance.
> 
> > diff --git a/drivers/pci/pcie/aer/aerdrv_errprint.c
> b/drivers/pci/pcie/aer/aerdrv_errprint.c
> []
> > @@ -228,9 +228,14 @@ void cper_print_aer(struct pci_dev *dev, int
> cper_severity,
> >  	int aer_severity, layer, agent, status_strs_size,
> tlp_header_valid = 0;
> >  	u32 status, mask;
> >  	const char **status_strs;
> > -	char *prefix = NULL;
> > +	char prefix[44];
> >
> >  	aer_severity = cper_severity_to_aer(cper_severity);
> > +	snprintf(prefix, sizeof(prefix), "%s%s %s: ",
> > +		(aer_severity == AER_CORRECTABLE) ?
> > +		KERN_WARNING : KERN_ERR,
> > +		dev_driver_string(&dev->dev), dev_name(&dev->dev));
> > +
> >  	if (aer_severity == AER_CORRECTABLE) {
> >  		status = aer->cor_status;
> >  		mask = aer->cor_mask;
> 
> Perhaps this would be better just using dev_printk
> instead of snprintf into a prefix with printk to
> emulate dev_printk.
> 
> Also, perhaps KERN_NOTICE is preferable to KERN_WARNING
> in the CORRECTABLE case.
> 
> Maybe something like:
> 
> 	const char *level = KERN_ERR;
> 	if (aer_severity == AER_CORRECTABLE)
> 		level = KERN_NOTICE;
> 
> 	...
> 
> 	dev_printk(level, &dev->dev, etc...);
> 
> Maybe do this after this series of patches is accepted.
> Enough with the revisions for awhile...

Hi Joe,

The reason I did it this way was I was trying to be consistent with what was done for the AER interrupt case.  The function aer_print_error()in the same file uses sprintf this way.  I'm not sure why they chose that instead of dev_printk.  I think if we did make the change we should do it in both places to keep them the same.  

Lance
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/