linux-kernel - Re: Look Ma, da kernel is b0rken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121205142935.GA12119@liondog.tnic>
Date:	Wed, 5 Dec 2012 15:29:35 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Andreas Mohr <andi@...as.de>
Cc:	linux-kernel@...r.kernel.org, Li Shaohua <shaohua.li@...el.com>,
	linux-acpi@...r.kernel.org
Subject: Re: Look Ma, da kernel is b0rken

On Wed, Dec 05, 2012 at 08:09:01AM +0100, Andreas Mohr wrote:
> Hi,
> 
> drivers/pnp/pnpacpi/core.c: In function 'ispnpidacpi':
> drivers/pnp/pnpacpi/core.c:65:2: warning: logical 'or' of collectively
> exhaustive tests is always true [-Wlogical-op]
> drivers/pnp/pnpacpi/core.c:66:2: warning: logical 'or' of collectively
> exhaustive tests is always true [-Wlogical-op]
> drivers/pnp/pnpacpi/core.c:67:2: warning: logical 'or' of collectively
> exhaustive tests is always true [-Wlogical-op]
> 
> 
> That's already the second less enticing -Wlogical-op issue
> which was discovered by accident during less than two days
> of my happy(?) activity of kernel suspend breakage bisection.
> 
> 
> Why oh why, as a rather *very* critical piece of software,
> can't the kernel use sufficiently aggressive warning levels *by default*??
> IMHO it's simply NOT ACCEPTABLE to have such sloppiness creep into
> the daily bandwagon of kernel development life
> (or should I say: being mandated to creep in?).
> 
> Result: whichever default warning level you set
> *will* end up as The New Normal,
> and all those warnings which then remain able to rear their ugly heads
> according to the chosen default level
> will be fixed by the community eventually,
> and *most others won't* (or at least not in time).
> 
> The amount of warnings spewn by make W=3 (or even W=2) is simply
> shocking IMNSHO.
> And there can always be an argument that most of such warnings
> are fixable. If not directly (e.g. because analysis of that warning type
> is partially unreliable), then by actively reworking code
> into something slightly different.

Can we all relax ourselves first?

Now, I admit that ispnpidacpi() is a rather clumsy way of testing
string sanity but whatever, it is there.

Then, we added W= exactly for inquisitive and adventurous people like
yourself to build kernel compilation units with, to *verify* the
*sanity* of the compiler's error messages (yes, gcc has been wrong a lot
in the past too) and fix them.

So why not write a patch that fixes this, *test* it correctly and then
submit it to the proper maintainer instead of ranting about it without
any constructive help and thus piss off everybody on the ML?

And yes, bugs happen and this is the reality of it - programmers are
people and they make mistakes too. So I think helping out fix bugs is a
much more constructive way of spending your time instead of pissing off
the only people who can actually help you with your problem.

HTH.

-- 
Regards/Gruss,
    Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/