linux-kernel - Re: [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k3sxgz6g.fsf@rustcorp.com.au>
Date:	Wed, 05 Dec 2012 10:14:39 +1030
From:	Rusty Russell <rusty@...abs.org>
To:	Michal Marek <mmarek@...e.cz>, dhowells@...hat.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] MODSIGN: Fix comparison erros in scripts/sign-file

Michal Marek <mmarek@...e.cz> writes:

> Signed-off-by: Michal Marek <mmarek@...e.cz>
> ---
>  scripts/sign-file |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/sign-file b/scripts/sign-file
> index 87ca59d..974a20b 100755
> --- a/scripts/sign-file
> +++ b/scripts/sign-file
> @@ -156,12 +156,12 @@ sub asn1_extract($$@)
>  
>  	if ($l == 0x1) {
>  	    $len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1));
> -	} elsif ($l = 0x2) {
> +	} elsif ($l == 0x2) {
>  	    $len = unpack("n", substr(${$cursor->[2]}, $cursor->[0], 2));
> -	} elsif ($l = 0x3) {
> +	} elsif ($l == 0x3) {
>  	    $len = unpack("C", substr(${$cursor->[2]}, $cursor->[0], 1)) << 16;
>  	    $len = unpack("n", substr(${$cursor->[2]}, $cursor->[0] + 1, 2));
> -	} elsif ($l = 0x4) {
> +	} elsif ($l == 0x4) {
>  	    $len = unpack("N", substr(${$cursor->[2]}, $cursor->[0], 4));
>  	} else {
>  	    die $x509, ": ", $cursor->[0], ": ASN.1 element too long (", $l, ")\n";

This was already applied to Linus' tree as 

commit 916492b1e1a186260951831c53a53d8a448dc026
Author: Chun-Yi Lee <jlee@...e.com>
Date:   Wed Nov 21 11:26:09 2012 +0000

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/