lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 05 Dec 2012 10:07:34 +0800 From: Tang Chen <tangchen@...fujitsu.com> To: Jianguo Wu <wujianguo@...wei.com> CC: Wen Congyang <wency@...fujitsu.com>, x86@...nel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-acpi@...r.kernel.org, linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, linux-ia64@...r.kernel.org, cmetcalf@...era.com, sparclinux@...r.kernel.org, David Rientjes <rientjes@...gle.com>, Jiang Liu <liuj97@...il.com>, Len Brown <len.brown@...el.com>, benh@...nel.crashing.org, paulus@...ba.org, Christoph Lameter <cl@...ux.com>, Minchan Kim <minchan.kim@...il.com>, Andrew Morton <akpm@...ux-foundation.org>, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com> Subject: Re: [Patch v4 08/12] memory-hotplug: remove memmap of sparse-vmemmap Hi Wu, On 12/04/2012 08:20 PM, Jianguo Wu wrote: (snip) >> >> Seems that we have different ways to handle pages allocated by bootmem >> or by regular allocator. Is the checking way in [PATCH 09/12] available >> here ? >> >> + /* bootmem page has reserved flag */ >> + if (PageReserved(page)) { >> ...... >> + } >> >> If so, I think we can just merge these two functions. > > Hmm, direct mapping table isn't allocated by bootmem allocator such as memblock, can't be free by put_page_bootmem(). > But I will try to merge these two functions. > Oh, I didn't notice this, thanks. :) (snip) >>> + >>> + __split_large_page(kpte, address, pbase); >> >> Is this patch going to replace [PATCH 08/12] ? >> > > I wish to replace [PATCH 08/12], but need Congyang and Yasuaki to confirm first:) > >> If so, __split_large_page() was added and exported in [PATCH 09/12], >> then we should move it here, right ? > > yes. > > and what do you think about moving vmemmap_pud[pmd/pte]_remove() to arch/x86/mm/init_64.c, > to be consistent with vmemmap_populate() ? It is a good idea since pud/pmd/pte related code could be platform dependent. And I'm also trying to move vmemmap_free() to arch/x86/mm/init_64.c too. I want to have a common interface just like vmemmap_populate(). :) > > I will rework [PATCH 08/12] and [PATCH 09/12] soon. I am rebasing the whole patch set now. And I think I chould finish part of your work too. A new patch-set is coming soon, and your rework is also welcome. :) Thanks. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists