linux-kernel - Re: [RFC PATCH 3/6] kvm: Merge id_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1354748302.3224.58.camel@bling.home>
Date:	Wed, 05 Dec 2012 15:58:22 -0700
From:	Alex Williamson <alex.williamson@...hat.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
Cc:	kvm@...r.kernel.org, gleb@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/6] kvm: Merge id_to_index into memslots

On Wed, 2012-12-05 at 19:22 -0200, Marcelo Tosatti wrote:
> On Mon, Dec 03, 2012 at 04:39:24PM -0700, Alex Williamson wrote:
> > This allows us to resize this structure and therefore the number of
> > memslots as part of the RCU update.
> 
> Why is this necessary? "struct memslots" is updated, message above
> conflicts with that.
> 
> If there is a reason, "id_to_index" becomes confusing.
> 

I can't have two indeterminate sized arrays in the same structure, so by
moving id_to_index into struct kvm_memory_slot I get back to one array.
I'm playing with whether this is worthwhile.  If we reduce id_to_index
to a short then we can leave it with a static size and still get a
memory savings for the typical case.  Thanks,

Alex

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/