linux-kernel - RE: [PATCH] da8xx: Allow use by am33xx based devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 6 Dec 2012 08:08:19 +0000
From:	"Manjunathappa, Prakash" <prakash.pm@...com>
To:	"Valkeinen, Tomi" <tomi.valkeinen@...com>
CC:	"linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Koen Kooi <koen@...inion.thruhere.net>,
	"Porter, Matt" <mporter@...com>, "Dill, Russ" <russ.dill@...com>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"FlorianSchandinat@....de" <FlorianSchandinat@....de>,
	Pantelis Antoniou <panto@...oniou-consulting.com>
Subject: RE: [PATCH] da8xx: Allow use by am33xx based devices

Hi Tomi,

On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote:
> Hi,
> 
> On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
> > This driver can be used for AM33xx devices, like the popular beaglebone.
> > 
> > Signed-off-by: Pantelis Antoniou <panto@...oniou-consulting.com>
> > ---
> >  drivers/video/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> > index 9791d10..e7868d8 100644
> > --- a/drivers/video/Kconfig
> > +++ b/drivers/video/Kconfig
> > @@ -2202,7 +2202,7 @@ config FB_SH7760
> >  
> >  config FB_DA8XX
> >  	tristate "DA8xx/OMAP-L1xx Framebuffer support"
> > -	depends on FB && ARCH_DAVINCI_DA8XX
> > +	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
> 
> Agreed this is present on da8xx and am33xx, but moving forward for
> supporting DT, we should be avoiding these dependencies. So instead
> change this to remove machine dependencies.
> 

I could be wrong here, having dependency on platform seems to be right.
Otherwise may lead to build errors for other platforms. Please ignore my
comments and accept this patch.

Thanks,
Prakash
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/