lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20121206002742.80C2A3E0E22@localhost> Date: Thu, 06 Dec 2012 00:27:42 +0000 From: Grant Likely <grant.likely@...retlab.ca> To: Bill Pemberton <wfp5p@...idian.itc.virginia.edu> Cc: Greg KH <gregkh@...uxfoundation.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option On Wed, 21 Nov 2012 20:07:23 -0500, wfp5p@...idian.itc.virginia.edu (Bill Pemberton) wrote: > Grant Likely writes: > > > > You mean this series wasn't created with a script? You did this by > > hand? If so then I must say kudos on your dedication! > > > > But it makes me more nervous about the series. Too easy to fat > > finger many things when touching that many files. > > > > No, I didn't do them by hand, it was a script. Originally, it was a > couple, all basically the same, but removing each __dev*. Then I'd do > a word diff to eyeball them to make sure the script didn't do > something goofy. > > The whack-a-mole part came along because I was working against > linux-next and whatever patch series was right for one day wouldn't be > right for the next day because of some of the faster moving trees. > > > > Please do write a script and post that for review. > > > > The all-in-one version of the script: > > #! /usr/bin/perl > > use strict; > use IO::InSitu; > > sub processfile > { > my $fn = shift; > > my ($in, $out) = open_rw($fn, $fn); > > while (<$in>) { > s|__devexit_p\(([^)]+)\)|$1|; > s|\s__devexit\b||; > s|\s__devinitconst\b||; > s|\s__devinitdata\b||; > s|\s__devinit\b||; Pretty straight forward, and works against the files I tried. :-) Greg, I'd much rather see the change applied all at once in this manner. If that isn't possible, then at the least I'll use the script against the code that I maintain and push th result out to Linus. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists