linux-kernel - Re: [PATCH 3/6 v2] staging/rtl8192u: indent with tabs, not spaces

Open Source and information security mailing list archives

Message-ID: <CAHdPZaPGKPGDB-1=3KX3zrop9Hr42JB-GcD4F-wLKRi5SygqdQ@mail.gmail.com>
Date:	Thu, 6 Dec 2012 07:55:27 -0500
From:	"devendra.aaru" <devendra.aaru@...il.com>
To:	Sebastian Hahn <snsehahn@....cs.fau.de>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	amwang@...hat.com,
	Jennifer.Naumann@...ormatik.stud.uni-erlangen.de, jkosina@...e.cz,
	linux-kernel@...r.kernel.org, Julia.Lawall@...6.fr,
	yongjun_wei@...ndmicro.com.cn, justinmattock@...il.com,
	joe@...ches.com, adam.buchbinder@...il.com,
	dan.carpenter@...cle.com,
	linux-kernel@...informatik.uni-erlangen.de
Subject: Re: [PATCH 3/6 v2] staging/rtl8192u: indent with tabs, not spaces

Hi,

>From the next time onward while you put a patch with updated code
change as mentioned by reviewers, you tell what changed in the next
interation.

like the below,

otherthan that your patch is good,

On Thu, Dec 6, 2012 at 6:23 AM, Sebastian Hahn <snsehahn@....cs.fau.de> wrote:
> Converted staging/rtl8187se to use tabs instead of spaces for
> indentation to fix the checkpatch error "code indent should use tabs
> where possible".
>
> Signed-off-by: Sebastian Hahn <snsehahn@....cs.fau.de>
> ---
V2:
    Removed .c.bak file as suggested by Dan.

>  drivers/staging/rtl8192u/ieee80211/ieee80211.h     |   14 +-
>  drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c  |  370 ++++++++++----------
>  .../staging/rtl8192u/ieee80211/ieee80211_softmac.c |    4 +-
>  drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c  |   14 +-
>  drivers/staging/rtl8192u/ieee80211/rtl_crypto.h    |   84 ++---
>  drivers/staging/rtl8192u/r8180_93cx6.c             |    2 +-
>  drivers/staging/rtl8192u/r8180_pm.h                |    2 +-
>  drivers/staging/rtl8192u/r8192U.h                  |  198 +++++------
>  drivers/staging/rtl8192u/r8192U_core.c             |   42 +--
>  9 files changed, 365 insertions(+), 365 deletions(-)
>

> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives