linux-kernel - Re: [BUGFIX PATCH] rtc: eliminate extra call of ida_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <50C0B704.5050808@ahsoftware.de>
Date:	Thu, 06 Dec 2012 16:17:24 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	Lothar Waßmann <LW@...O-electronics.de>
CC:	Alessandro Zummo <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [BUGFIX PATCH] rtc: eliminate extra call of ida_simple_remove()

Am 05.12.2012 16:25, schrieb Lothar Waßmann:
> Unbinding an RTC chip driver from its device leads to the error
> message:
> |ida_remove called for id=0 which is not allocated.
>
> This is caused by a redundant call to ida_simple_remove() in
> rtc_device_unregister().
> Eliminate the call in rtc_device_unregister() and only call the
> function in rtc_device_release().
>
> Signed-off-by: Lothar Waßmann <LW@...O-electronics.de>

I've just discovered the same problem. Although I've removed the call to
ida_simple_remove() in rtc_device_release() (for symmetry of 
register/unregister) I can offer a

Signed-off-by: Alexander Holler

A

Cc: <stable@...r.kernel.org>

might make sense, but it should just remove a warning, so I don't know 
if that qualifies for the stable series.

Regards,

Alexander


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/