linux-kernel - RE: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A2436413A01D599@penmbx01>
Date:	Thu, 6 Dec 2012 00:54:48 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Florian Fainelli <florian@...nwrt.org>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>,
	"Lin, JM" <JM.Lin@...el.com>, "wim@...ana.be" <wim@...ana.be>,
	"linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the
 watchdog framework

Hi Florian,

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@...il.com] On Behalf Of Florian Fainelli
> Sent: 2012年12月5日 18:48
> To: Yang, Wenyou
> Cc: linux-arm-kernel@...ts.infradead.org; Ferre, Nicolas; plagnioj@...osoft.com; Lin,
> JM; wim@...ana.be; linux-watchdog@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [v2 PATCH 2/8] watchdog/at91sam9_wdt: Convert to use the watchdog
> framework
> 
> Hello Wenyou,
> 
> On Wednesday 05 December 2012 09:34:21 Wenyou Yang wrote:
> > According to the kernel document: convert_drivers_to_kernel_api.txt,
> > remove the file_operations struct, miscdevice, and obsolete includes
> >
> > Since the at91sam watchdog inherent characteristics, add the watchdog
> > operations: at91wdt_start, at91wdt_stop and at91wdt_ping.
> >
> 
> [snip]
> 
> >
> > +static inline bool watchdog_is_open(struct watchdog_device *wddev)
> > +{
> > +	return test_bit(WDOG_DEV_OPEN, &wddev->status);
> > +}
> 
> This helper should be moved to include/linux/watchdog.h as it can be useful
> for other watchdog drivers as well.

Thanks, I will move it in next version.

> --
> Florian

Best Regards
Wenyou Yang