linux-kernel - Re: [PATCH] x86: ptrace.c only needs export.h and not the full module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121206163439.GA10797@windriver.com>
Date:	Thu, 6 Dec 2012 11:34:39 -0500
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>, <rob@...dley.net>
Subject: Re: [PATCH] x86: ptrace.c only needs export.h and not the full
 module.h

[Re: [PATCH] x86: ptrace.c only needs export.h and not the full module.h] On 06/12/2012 (Thu 17:17) Borislav Petkov wrote:

> On Thu, Dec 06, 2012 at 06:33:42AM -0500, Paul Gortmaker wrote:
> > Commit cb57a2b4cff7edf2a4e32c0163200e9434807e0a ("x86-32: Export
> > kernel_stack_pointer() for modules") added an include of the
> > module.h header in conjunction with adding an EXPORT_SYMBOL_GPL
> > of kernel_stack_pointer.
> > 
> > But module.h should be avoided for simple exports, since it in turn
> > includes the world.  Swap the module.h for export.h instead.
> 
> If this is the preferred include for EXPORT_SYMBOL* stuff now, maybe we
> should hold this down somewhere in writing or add it to checkpatch?

Good point.  Fixed below.

Thanks,
Paul.


>From 6d7ea827572bf4a5b7c0bd6ae3f12f5be0a7c7c2 Mon Sep 17 00:00:00 2001
From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Thu, 6 Dec 2012 11:26:53 -0500
Subject: [PATCH] DocBook: update EXPORT_SYMBOL entry to point at export.h

Previously we used to get EXPORT_SYMBOL and friends from
module.h but we moved away from that since module.h largely
includes the entire header space one way or another.

As most users just wanted the simple export related macros,
they were spun off into a separate new header -- export.h
Update the docs to reflect that.

Suggested-by: Borislav Petkov <bp@...en8.de>
Cc: Rob Landley <rob@...dley.net>
Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
---
 Documentation/DocBook/kernel-hacking.tmpl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/DocBook/kernel-hacking.tmpl b/Documentation/DocBook/kernel-hacking.tmpl
index eee7142..a23bc37 100644
--- a/Documentation/DocBook/kernel-hacking.tmpl
+++ b/Documentation/DocBook/kernel-hacking.tmpl
@@ -945,7 +945,7 @@ printk(KERN_INFO "my ip: %pI4\n", &amp;ipaddress);
 
   <sect1 id="sym-exportsymbols">
    <title><function>EXPORT_SYMBOL()</function>
-    <filename class="headerfile">include/linux/module.h</filename></title>
+    <filename class="headerfile">include/linux/export.h</filename></title>
 
    <para>
     This is the classic method of exporting a symbol: dynamically
@@ -955,7 +955,7 @@ printk(KERN_INFO "my ip: %pI4\n", &amp;ipaddress);
 
   <sect1 id="sym-exportsymbols-gpl">
    <title><function>EXPORT_SYMBOL_GPL()</function>
-    <filename class="headerfile">include/linux/module.h</filename></title>
+    <filename class="headerfile">include/linux/export.h</filename></title>
 
    <para>
     Similar to <function>EXPORT_SYMBOL()</function> except that the
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/