lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAKohpon3uW2N3Kaj_HkjVsUZ0+9oOHtPev=okyP50BxSKz7ntQ@mail.gmail.com> Date: Thu, 6 Dec 2012 22:17:21 +0530 From: Viresh Kumar <viresh.kumar@...aro.org> To: Lee Jones <lee.jones@...aro.org> Cc: sameo@...ux.intel.com, devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org, spear-devel@...t.st.com, Vipul Kumar Samar <vipulkumar.samar@...com> Subject: Re: [PATCH V6] mfd: stmpe: Update DT support for stmpe driver On 6 December 2012 22:10, Lee Jones <lee.jones@...aro.org> wrote: > On Thu, 06 Dec 2012, Viresh Kumar wrote: >> + pdata->id = -1; > > Perhaps PLATFORM_DEVID_AUTO would be better? Why do we want to allocate device id's for it? Multiple devices are already distinguished and so -1 would be better. >> + pdata->irq_trigger = IRQF_TRIGGER_NONE; >> + > > There's no need for this. It's guaranteed to be zero by: > > pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); I kept it so that in future others don't think that we missed handling of irq_trigger for DT case. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists