[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1354846144.2795.76.camel@fourier>
Date: Thu, 06 Dec 2012 18:09:04 -0800
From: Kamal Mostafa <kamal@...onical.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
Henrik Rydberg <rydberg@...omail.se>,
Dudley Du <dudl@...ress.com>, David Solda <dso@...ress.com>,
Troy Abercrombia <ta@...ress.com>,
Kyle Fazzari <git@...tus.e4ward.com>,
Mario Limonciello <mario_limonciello@...l.com>,
Tim Gardner <tim.gardner@...onical.com>,
Herton Krzesinski <herton.krzesinski@...onical.com>
Subject: Re: [PATCH v5 2/3] input: Cypress PS/2 Trackpad psmouse driver
On Thu, 2012-12-06 at 00:08 -0800, Dmitry Torokhov wrote:
> [...]
Hi Dmitry-
Thanks again for your review. The forthcoming PATCH v6 addresses all of
your requests, except for:
> > + __set_bit(INPUT_PROP_BUTTONPAD, input->propbit);
>
> I do not think it should be marked INPUT_PROP_BUTTONPAD if it has
> physical buttons...
This device (my particular Cypress Trackpad unit anyway) does not have
physical buttons. The pad is clickable; I think it is a standard
"buttonpad" device.
And just FYI, this issue has been addressed but to answer your question:
> > +
> > + if (cytp->mode & CYTP_BIT_ABS_MASK) {
>
> It can't be anything else, can it?
It can: in the case when the mode hasn't been set at all yet (during
detect and reconnect). I cleaned up the logic of this routine
(cypress_validate_byte) and added explanatory comments.
-Kamal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists