linux-kernel - Re: [PATCH 3.7-rc8] ttm: Fix possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPM=9tyENuyjNYdRZM0Z-tWZsQ5TnHadtByXWv7yNE0j0gwxpQ@mail.gmail.com>
Date:	Fri, 7 Dec 2012 15:59:53 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Tim Gardner <tim.gardner@...onical.com>
Cc:	linux-kernel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	dri-devel@...ts.freedesktop.org,
	David Howells <dhowells@...hat.com>,
	Dave Airlie <airlied@...hat.com>
Subject: Re: [PATCH 3.7-rc8] ttm: Fix possible _manager memory allocation oops

On Fri, Dec 7, 2012 at 9:05 AM, Tim Gardner <tim.gardner@...onical.com> wrote:
> On 12/06/2012 03:46 PM, Dave Airlie wrote:
>
>>>
>>>          ttm_page_pool_init_locked(&_manager->wc_pool, GFP_HIGHUSER,
>>> "wc");
>>>
>>> @@ -817,6 +821,7 @@ int ttm_page_alloc_init(struct ttm_mem_global *glob,
>>> unsigned max_pages)
>>>                                     &glob->kobj, "pool");
>>>          if (unlikely(ret != 0)) {
>>>                  kobject_put(&_manager->kobj);
>>> +               kfree(_manager);
>>>                  _manager = NULL;
>>
>>
>> I don;t think this is, since the kobject_put shuold free it.
>>
>
> kobject_put only frees memory referenced by kobj, but not the memory pointed
> at by _manager.
>

The memory pointed at by _manager is the memory freed by the kobj if I
read the code correctly.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/